927 copying steel equations from 2005 to 2025, for those that are the same, batch 4#931
927 copying steel equations from 2005 to 2025, for those that are the same, batch 4#931egarciamendez merged 91 commits intomainfrom
Conversation
…r holes in EN 1993-1-1:2025
…n in EN 1993-1-1:2025
…n in EN 1993-1-1:2025
… EN 1993-1-1:2025
…7, 8.19, 8.22, and 8.23 to follow naming convention
… EN 1993-1-1:2025
…calculation in EN 1993-1-1:2025
…n in EN 1993-1-1:2025
… sections according to EN 1993-1-1:2025
…ance in structural hollow sections according to EN 1993-1-1:2025
…rding to NEN-EN 1993-1-1+A1:2016
…ccording to EN 1993-1-1:2025
…ithout torsion according to EN 1993-1-1:2025
…rectangular solid sections according to EN 1993-1-1:2025
…cording to EN 1993-1-1:2025
…cording to EN 1993-1-1:2025
…cording to EN 1993-1-1:2025
…to EN 1993-1-1:2025
…g to EN 1993-1-1:2025
…to EN 1993-1-1:2025
…to EN 1993-1-1:2025
…to EN 1993-1-1:2025
… and 8.37 validation
…parameter naming conventions
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughA new package structure for EN 1993-1-1:2025 is introduced, adding three formula implementations from Chapter 8 (Ultimate Limit State) that compute design plastic shear resistance and shear stress calculations, along with comprehensive test coverage for each formula. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 435 438 +3
Lines 13515 13588 +73
=========================================
+ Hits 13515 13588 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… in formulas and tests
…lueprints into 927_code_batch4
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@tests/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/__init__.py`:
- Line 1: The module docstring incorrectly references "Chapter 6" while the
package is chapter_8_ultimate_limit_state; update the top-level docstring in
__init__.py to say "Chapter 8 - Ultimate limit state" (or otherwise reference
Chapter 8) so the description matches the package name and contents.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0c8bb80e-733e-4650-9129-9349b6277423
📒 Files selected for processing (10)
blueprints/codes/eurocode/en_1993_1_1_2025/__init__.pyblueprints/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/__init__.pyblueprints/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/formula_8_23.pyblueprints/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/formula_8_25.pyblueprints/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/formula_8_26.pytests/codes/eurocode/en_1993_1_1_2025/__init__.pytests/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/__init__.pytests/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/test_formula_8_23.pytests/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/test_formula_8_25.pytests/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/test_formula_8_26.py
tests/codes/eurocode/en_1993_1_1_2025/chapter_8_ultimate_limit_state/__init__.py
Outdated
Show resolved
Hide resolved
2 participants
Description
Type of change
Please delete options that are not relevant.
Checklist:
Summary by CodeRabbit